Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --response option from HTTP Commands #426

Closed
tlmii opened this issue Nov 3, 2020 · 0 comments · Fixed by #429
Closed

Remove --response option from HTTP Commands #426

tlmii opened this issue Nov 3, 2020 · 0 comments · Fixed by #429
Labels
5.0-dash Potential final items for 5.0
Milestone

Comments

@tlmii
Copy link
Member

tlmii commented Nov 3, 2020

Per #407 it doesn't actually work, and has never worked. The user will still have --response:Body and --response:Header that do work. But we don't want the help and documentation pointing to something they can't actually use.

The only real functional change here will be ensuring that the user doesn't specify the same file for both - that was the long-form equivalent of --response, is also broken and, per #404, we don't really have a good idea of what the structure of that file should be anyway. So we can just error out if they do try that.

@tlmii tlmii added the 5.0-dash Potential final items for 5.0 label Nov 3, 2020
@tlmii tlmii added this to the 5.0.0 milestone Nov 3, 2020
@tlmii tlmii closed this as completed in #429 Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0-dash Potential final items for 5.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant