About rxandroidble version

[hanabi1224]

Hello, I notice this library is currently using com.polidea.rxandroidble:rxandroidble:1.7.0 which was released a year ago, is there plan to upgrade to com.polidea.rxandroidble2 with latest changes? Thanks!

[mikolak]

Hi @hanabi1224 !

I've talked to @dariuszseweryn and IIRC introducing RxAndroidBLE 2 would break the libraries using this one. Are there any specific changes you need?

[hanabi1224]

@mikolak Ah not really, my project is currently using flutter_blue and I'm investigating whether FlutterBleLib is a better solution. A stale core dependency with no upgrade path/plan seems to be a risk tho

[dariuszseweryn]

I have plans for changing RxAndroidBle API so it will be possible to fully encapsulate RxJava2 so it could be an implementation detail (which is currently a problem due to RxJava2 design decisions)

[hanabi1224]

@dariuszseweryn Awesome, looking forward to that!

[JamesMcIntosh]

Hi @dariuszseweryn & @mikolak,
I see that you are no longer actively developing the RxAndroidBle RxJava1 branch.
RxJava1 was end of life 2.5 years ago, shouldn't it be reasonable to make a legacy branch for RxJava1 support in this repository and make the master branch RxJava2 and bump the version to 2.x?
Thanks James

[JamesMcIntosh]

Hi @dariuszseweryn & @mikolak,
I've submitted a pull request #67 which migrates to RxJava2
Kind regards
James

[JamesMcIntosh]

Hi @hanabi1224 !

I've talked to @dariuszseweryn and IIRC introducing RxAndroidBLE 2 would break the libraries using this one. Are there any specific changes you need?

I have updated the version of MultiPlatformBleAdapter in FlutterBleLibPlugin without having to change a line of code as the MultiPlatformBleAdapter API is built around callbacks which hide the RxJava implementation from view. (nice work!)
I would therefore expect other clients to be able to be updated without much issue unless they depend on the transitive dependency of RxJava1.

[JamesMcIntosh]

@hanabi1224 RxJava2 branch is now available
https://github.com/Polidea/MultiPlatformBleAdapter/tree/beta/rxandroible2

@mikolak close the issue?

[mikolak]

Yeah. Man, we really need more manpower here, I completely forgot this issue existed at all...