Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new Bound API of pyO3 #437

Closed
phil-opp opened this issue Mar 15, 2024 · 2 comments · Fixed by #472
Closed

Use new Bound API of pyO3 #437

phil-opp opened this issue Mar 15, 2024 · 2 comments · Fixed by #472
Labels
documentation Improvements or additions to documentation enhancement New feature or request performance python Python API runtime

Comments

@phil-opp
Copy link
Collaborator

phil-opp commented Mar 15, 2024 •
edited
Loading

We use the pyO3 crate for implementing Python nodes and operators. The upcoming v0.21 release will feature a new "Bound" API, which enables better control over the lifetimes of GIL-references, while also improving performance. It also solve PyO3/pyo3#1056, which we encountered in dora.

Right now v0.21 is still in beta, but we should try to migrate dora to the new Bound API once the stable is out.

(Maybe it will even allow us to bring back runtime nodes with multiple Python operators?)
@phil-opp phil-opp added enhancement New feature or request performance python Python API runtime labels Mar 15, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 15, 2024
@haixuanTao
Copy link
Collaborator

I think this could solve one of the issues with drop tokens reporting at the end of running dataflows.

@haixuanTao
Copy link
Collaborator

https://github.com/PyO3/pyo3/releases/tag/v0.21.0

0.21 has been released!

@Michael-J-Ward Michael-J-Ward mentioned this issue Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request performance python Python API runtime
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Pyo3 bounds Michael-J-Ward/dora
2 participants
@phil-opp @haixuanTao