Does not resolve to files in node_modules lower than root

[remko]

Steps to reproduce:

# npm install bootstrap

Root file works fine:

# ls node_modules/bootstrap/LICENSE
node_modules/bootstrap/LICENSE
# node
> require('resolve-file')('bootstrap/LICENSE')
'/path/to/node_modules/bootstrap/LICENSE'

Lower file does not:

# ls node_modules/bootstrap/dist/js/bootstrap.js
node_modules/bootstrap/dist/js/bootstrap.js

# node
> require('resolve-file')('bootstrap/dist/js/bootstrap.js')
null

[baurine]

The similar issue, it is not that it can't resolve files lower than the root folder, but it can't resolve the files that are not the entry files and are not under the root folder.

But it works if we call the require.resolve() directly.

Test code:

const resolveFile = require('resolve-file')

console.log(resolveFile('esbuild-plugin-postcss2/LICENSE'))
// output: /repo_path/node_modules/esbuild-plugin-postcss2/LICENSE

console.log(resolveFile('esbuild-plugin-postcss2/dist/index.js'))
// output: /repo_path/node_modules/esbuild-plugin-postcss2/dist/index.js

console.log(resolveFile('esbuild-plugin-postcss2/dist/index.esm.js'))
// output: /repo_path/node_modules/esbuild-plugin-postcss2/dist/index.esm.js

console.log(resolveFile('esbuild-plugin-postcss2/src/modules.d.ts'))
// output: null

// directly use require.resolve
console.log(require.resolve('esbuild-plugin-postcss2/src/modules.d.ts'))
// output: /repo_path/node_modules/esbuild-plugin-postcss2/src/modules.d.ts

I don't understand the below code logic very much:

resolve-file/index.js

Lines 98 to 106 in f598211

	if (!utils.exists(file.path)) {
	try {
	if (/[\\\/]/.test(name)) {
	file.basename = path.basename(name);
	var dirname = path.dirname(name);
	file.name = path.basename(dirname);
	file.main = require.resolve(dirname);
	file.path = path.resolve(path.dirname(file.main), file.basename);
	}

  if (!utils.exists(file.path)) {
    try {
      if (/[\\\/]/.test(name)) {
        file.basename = path.basename(name);
        var dirname = path.dirname(name);
        file.name = path.basename(dirname);
        file.main = require.resolve(dirname);
        file.path = path.resolve(path.dirname(file.main), file.basename);
      }

Why do we call require.resolve(dirname), not require.resolve(name)? If we call require.resolve(name) then we can get the expected result.

@doowb