Memoize nil doorkeeper_token #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some applications extending `AccessToken` class with custom functionality, it's some times required to call `doorkeeper_token` method directly. If this method is called multiple times, it can cause repeated DB calls when there's an invalid token that returns `nil` from the `OAuth::Token.authenticate` call. This could be improved by doing similar as in `current_resource_owner`, where it memoizes `nil` return values for `instance_eval(&Doorkeeper.config.authenticate_resource_owner)` With this proposed change, it will memoize `nil` doorkeeper_token values too.
Generated by 🚫 Danger |
This was referenced Mar 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some applications extending
AccessTokenclass with customfunctionality, it's some times required to call
doorkeeper_tokenmethod directly. If this method is called multiple times, it can cause
repeated DB calls when there's an invalid token that returns
nilfromthe
OAuth::Token.authenticatecall.This could be improved by doing similar as in
current_resource_owner,where it memoizes
nilreturn values forinstance_eval(&Doorkeeper.config.authenticate_resource_owner)With this proposed change, it will memoize
nildoorkeeper_tokenvalues too.