Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use built-in option to remove padding #1459

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Conversation

dee-see
Copy link
Contributor

@dee-see dee-see commented Dec 10, 2020

Summary

I was reading the code and came across how the padding is stripped from the code_challenge. There's a builtin option in Base64.urlsafe_encode64(..., padding: false) to do that. Tiny tiny change but we're saving a split. :)

@doorkeeper-bot
Copy link

2 Warnings
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.
⚠️ Please include a changelog entry.
You can find it at CHANGELOG.md.You can skip this warning only if you made some typo fix or other small changes that didn't affect the API.

Here's an example of a CHANGELOG.md entry:

- [#1459] Use built-in option to remove padding.

Generated by 🚫 Danger

@dee-see
Copy link
Contributor Author

dee-see commented Dec 11, 2020

I think we can skip the changelog for this?

@nbulaj
Copy link
Member

nbulaj commented Dec 11, 2020

You don't know @dee-see how I love such changes 👍
Thanks! Yeah, no need in changelog I think

@nbulaj nbulaj merged commit b95bd02 into doorkeeper-gem:master Dec 11, 2020
@dee-see dee-see deleted the patch-1 branch December 11, 2020 11:53
@nbulaj nbulaj added this to the 5.5 milestone Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants