Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate empty host in redirect_uri #1440

Merged
merged 1 commit into from
Sep 3, 2020
Merged

Validate empty host in redirect_uri #1440

merged 1 commit into from
Sep 3, 2020

Conversation

igor-drozdov
Copy link

@igor-drozdov igor-drozdov commented Sep 2, 2020 •
edited
Loading

Summary

When http:// or https:// is specified as redirect_uri, we should expect it to be invalid

We had this behavior until these changes have been specified: ebedb3c#diff-1de26e1e806e732aaaf8b2010ee70af7L25

@igor-drozdov igor-drozdov force-pushed the validate-empty-host-in-redirect-uri branch from 0229cfc to 5ac287f Compare September 2, 2020 07:28
nbulaj
nbulaj approved these changes Sep 3, 2020
View reviewed changes
Copy link
Member

@nbulaj nbulaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

@nbulaj nbulaj merged commit c54e731 into doorkeeper-gem:master Sep 3, 2020
@nbulaj
Copy link
Member

nbulaj commented Sep 3, 2020

Thanks @igor-drozdov !

@igor-drozdov igor-drozdov deleted the validate-empty-host-in-redirect-uri branch September 3, 2020 07:30
@nbulaj nbulaj added this to the 5.5 milestone Jan 13, 2021
This was referenced Mar 17, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbulaj nbulaj nbulaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.5
Development

Successfully merging this pull request may close these issues.
2 participants
@igor-drozdov @nbulaj