-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix menu multiline strings #87
Comments
I would like to work on this issue. I took a look at skyrim-community-shaders/src/Menu.cpp Lines 361 to 365 in b105489
and skyrim-community-shaders/src/Menu.cpp Lines 513 to 515 in b105489
I noticed in the above two snippets, the final sentences also have an extra space after the period, which isn't present in the multiline text string example provided: Is the extra space also required in the last sentence for proper word wrapping? |
Awesome. No it's not required for the final string, it's just a habit. The reason it's required in the other strings is cpp will concatenate two strings together. So "This is" "a sentence" will end up as "This isa sentence". |
I've added my changes to #119. I noticed the following tooltips that were multi-sentenced but already in one text field, but did not modify them:
I've made a note of these tooltips in the above Pull Request. Should these tooltips also be modified? |
Right now, the imgui menu handle multiline text by using multiple text fields. This actually is bad as it will break wrapping depending on window size.
The better solution is to change to a multiline text string. Note extra space at end after period. This will allow proper word wrapping.
The text was updated successfully, but these errors were encountered: