add custom path for ios #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyochan
approved these changes
Feb 11, 2020
|
@RZulfikri @hyochan This is a great fix, that was what I was trying to do but I don't have any knowledge of Objective C. |
escobar5
added a commit
to escobar5/react-native-audio-recorder-player
that referenced
this pull request
Mar 31, 2020
PR hyochan#168 fixed the possibility to add a custom path on iOS, but only for startPlayer, the same code is in startRecorder, so I replicated the change in that method also.
hyochan
pushed a commit
that referenced
this pull request
Apr 18, 2020
PR #168 fixed the possibility to add a custom path on iOS, but only for startPlayer, the same code is in startRecorder, so I replicated the change in that method also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update:
add custom path for ios in
startPlayermethod. Currently,startPlayeronly accepts file name with the default parent directory (Cache Directory). So I add the condition to check ifpathcontainsfile://then usepath, else append default parent directory into path file.