Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed RN60 CocoaPods installation #106

Merged
merged 2 commits into from
Aug 28, 2019
Merged

fixed RN60 CocoaPods installation #106

merged 2 commits into from
Aug 28, 2019

Conversation

netbull
Copy link
Contributor

@netbull netbull commented Aug 22, 2019

No description provided.

@nerami
Copy link

nerami commented Aug 22, 2019

@netbull why don't we just move the existing podspec in ios/RNAudioRecorderPlayer.podspec to the root to avoid duplicates? Or we can just delete the old one.

@netbull
Copy link
Contributor Author

netbull commented Aug 22, 2019

I’m not really sure... I saw that it is the same in the package of react-native-cameraroll and it works...

@netbull
Copy link
Contributor Author

netbull commented Aug 23, 2019

@NRamirezCR yes, the podspec file inside ios/ was not needed.

@netbull
Copy link
Contributor Author

netbull commented Aug 24, 2019

@hyochan any update on this?

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not tested this yet but if it works in your env I'll just publish to a newer version and try to manage issues in the future.

Thanks for your contribution.

@hyochan hyochan merged commit 66c21d2 into hyochan:master Aug 28, 2019
@hyochan
Copy link
Owner

hyochan commented Aug 28, 2019

Related #99 #98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants