Fix double call of result reply on connection init #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hyochan can you make a release with this please? |
|
@letiagoalves Thanks for the reminder. I've just tested |
|
Released in |
|
Thank you @hyochan. I will make a release of my app with this new version and see if it fixes the fatal crashes I am having right now in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
I've been debugging and looking for possible reasons for "Reply already submitted" message that I've been able to catch on my own device and the only thing that could cause it is calling
result.successorresult.errortwice or more ononBillingSetupFinished. And digging into the RN IAP lib led me to this quite similar problem occurred once not so long ago hyochan/react-native-iap#315This improvement should protect the
resultand ensure it is replied no more than once.