Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for "KHR_materials_clearcoat", "KHR_materials_transmission", "KHR_materials_sheen" #233

Closed
rawwerks opened this issue Dec 21, 2020 · 6 comments

Comments

@rawwerks
Copy link

i love this resource. it would fantastic if it were updated to support the 3 new PBR extensions (https://gfxspeak.com/2020/12/03/physically-rendering-extensions/)

image

Left is is https://gltf-viewer.donmccurdy.com/ , right is https://sandbox.babylonjs.com/.

Thank you!

@donmccurdy
Copy link
Owner

donmccurdy commented Dec 21, 2020

Hi! I believe KHR_materials_clearcoat is already supported (let me know if you have trouble with it!), but you're correct that the others are not yet. This viewer depends on three.js for rendering, and so three.js would need to add support for these extensions first. If you'd be interested in leaving an upvote or comment there, I believe that mrdoob/three.js#16977 is the relevant issue.

@cx20
Copy link

cx20 commented Aug 7, 2021

BTW, I think three.js r131 supports KHR_materials_transmission.

@donmccurdy
Copy link
Owner

Just updated to r131 – should include transmission, volume, and IOR if I'm not mistaken. Sheen is still not really supported, but I'll close out this issue for now since there hasn't been movement on that in three.js for a while.

Screen Shot 2021-08-07 at 9 35 51 AM

@cx20
Copy link

cx20 commented Aug 7, 2021

Thank you for updating to the latest version.
However, when I tried it, it seems that there is an error in the console.
https://gltf-viewer.donmccurdy.com/

app.js:1 
Uncaught SyntaxError: Cannot use import statement outside a module

Is it a problem with my environment?
Environment: Windows 10 + Chrome 92

@donmccurdy
Copy link
Owner

Ah, thanks! Should be fixed now.

@cx20
Copy link

cx20 commented Aug 7, 2021

Thank you for the quick fix. I think it's okay now.
glTF Viewer + Duck.gltf(use Transmission extension) result:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants