From 46b9d42eb4b64dc9140c15e0590eac92c0e7183f Mon Sep 17 00:00:00 2001 From: Hansini Karunarathne <107214435+hansinikarunarathne@users.noreply.github.com> Date: Mon, 20 May 2024 19:19:48 +0530 Subject: [PATCH] Create PR template (#2722) * Add issue report template Signed-off-by: hansinikarunarathne * Add config.yaml Signed-off-by: hansinikarunarathne * Adderessing the requested changes Signed-off-by: hansinikarunarathne * create PR template Signed-off-by: Hansini Karunarathne * create PR template Signed-off-by: Hansini Karunarathne * create PR template Signed-off-by: Hansini Karunarathne * create PR template Signed-off-by: Hansini Karunarathne * make changes to PR template folder Signed-off-by: Hansini Karunarathne * Address the requested changes Signed-off-by: Hansini Karunarathne --------- Signed-off-by: hansinikarunarathne Signed-off-by: Hansini Karunarathne --- .github/PULL_REQUEST_TEMPLATE.md | 36 ++++++++++++++++++++++++++++++++ .github/pull_request_template.md | 11 ---------- 2 files changed, 36 insertions(+), 11 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md delete mode 100644 .github/pull_request_template.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..48f8ef190b --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,36 @@ +# Pull Request Template for Kubeflow manifests Issues + +- Please include a summary of changes and the related issue. +- List any dependencies that are required for this change. +- Please delete the options that are not relevant. +- The following checklist will help you to satisfy the requirements. + + + +## ✏️ A brief description of the changes +> I changed ... + +## 📦 List any dependencies that are required for this change +> My PR depends on # + +## 🐛 If this PR is related to an issue, please put the link of the issue here. +> The following issues are related, because ... + + + +## ✅ Unit Test Checklist + + - [] 🛠️ Make sure you have installed kustomize == 5.2.1+ + - [] ✍️ Have you written new tests for your core changes, as applicable? + - [] 🔄 Have you successfully run existing tests with your changes ? + - [] 🚀 Have you successfully run existing and new tests with your changes ? + +## ✅ Contributor checklist + - [] All the commits have been _signed-off_ (To pass the `DCO` check) + - [] Submit the [Contributor License Agreements](https://cla.developers.google.com/clas) (To pass the `cla/google` check) + + +--- + +>You can join our slack channel **wg-manifests** [here](https://www.kubeflow.org/docs/about/community/). This link also contains our meeting schedule. + \ No newline at end of file diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md deleted file mode 100644 index f25245602c..0000000000 --- a/.github/pull_request_template.md +++ /dev/null @@ -1,11 +0,0 @@ -**Which issue is resolved by this Pull Request:** -Resolves # - -**Description of your changes:** - - -**Checklist:** -- [ ] Unit tests pass: - **Make sure you have installed kustomize == 5.2.1+** - 1. `make generate-changed-only` - 2. `make test`