Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug working with branch prefixes not ending with a slash #8

Open
k-bx opened this issue Feb 10, 2015 · 0 comments
Open

Bug working with branch prefixes not ending with a slash #8

k-bx opened this issue Feb 10, 2015 · 0 comments

Comments

@k-bx
Copy link

k-bx commented Feb 10, 2015

I had a setup where features were named as "abc-123-small-desc" (because of migration from jira), and started with same approach for github-pivotal-flow, but first time I tried to start a feature it suggested to me that branch-name will be abc-/<my-input>. Apparently, bug is in these lines:

https://github.com/donaldpiret/github-pivotal-flow/blob/master/lib/github_pivotal_flow/story.rb#L283:

prefix = "#{prefix.strip}/" unless prefix.strip[-1,1] == '/'

It hard-codes a slash in the end of a prefix. I think it shouldn't do this and either just take prefix, or do additional check if there's no '/' at the end -- don't append it also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant