From dc1aef752582c5c22b80d0dc3b4f2180155f37f8 Mon Sep 17 00:00:00 2001 From: Dominik Honnef Date: Tue, 28 Aug 2018 15:22:43 +0200 Subject: [PATCH] staticcheck: disable SA6004 until it's less noisy Updates gh-322 --- staticcheck/lint.go | 2 +- .../CheckSillyRegexp.go | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename staticcheck/testdata/src/{CheckSillyRegexp => CheckSillyRegexp.disabled}/CheckSillyRegexp.go (100%) diff --git a/staticcheck/lint.go b/staticcheck/lint.go index 9b5de1acb..3a890b7bb 100644 --- a/staticcheck/lint.go +++ b/staticcheck/lint.go @@ -285,7 +285,7 @@ func (c *Checker) Checks() []lint.Check { {ID: "SA6001", FilterGenerated: false, Fn: c.CheckMapBytesKey}, {ID: "SA6002", FilterGenerated: false, Fn: c.callChecker(checkSyncPoolValueRules)}, {ID: "SA6003", FilterGenerated: false, Fn: c.CheckRangeStringRunes}, - {ID: "SA6004", FilterGenerated: false, Fn: c.CheckSillyRegexp}, + // {ID: "SA6004", FilterGenerated: false, Fn: c.CheckSillyRegexp}, {ID: "SA9001", FilterGenerated: false, Fn: c.CheckDubiousDeferInChannelRangeLoop}, {ID: "SA9002", FilterGenerated: false, Fn: c.CheckNonOctalFileMode}, diff --git a/staticcheck/testdata/src/CheckSillyRegexp/CheckSillyRegexp.go b/staticcheck/testdata/src/CheckSillyRegexp.disabled/CheckSillyRegexp.go similarity index 100% rename from staticcheck/testdata/src/CheckSillyRegexp/CheckSillyRegexp.go rename to staticcheck/testdata/src/CheckSillyRegexp.disabled/CheckSillyRegexp.go