Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerDependency is not compat with sinon@8 #143

Closed
AviVahl opened this issue Dec 23, 2019 · 3 comments · Fixed by #144
Closed

peerDependency is not compat with sinon@8 #143

AviVahl opened this issue Dec 23, 2019 · 3 comments · Fixed by #144

Comments

@AviVahl
Copy link
Contributor

AviVahl commented Dec 23, 2019

sinon@8 got released yesterday, and sinon-chai specifies a lower peerDependency:

warning " > [email protected]" has incorrect peer dependency "sinon@>=4.0.0 <8.0.0".

FYI @domenic @simondel
@simondel
Copy link
Collaborator

Thanks for the heads-up! If anyone can make a PR, I’lol merge and release it tomorrow

@AviVahl AviVahl mentioned this issue Dec 23, 2019
Merged
@AviVahl
Copy link
Contributor Author

AviVahl commented Dec 23, 2019

@simondel ask and you shall receive: #144

simondel pushed a commit that referenced this issue Dec 24, 2019
@AviVahl @simondel
chore(infra): upgrade all deps (#144)
60df918 
- mark as compatible with sinon@9 (closes #143).
- fixed all `npm audit` errors.
- made sure Travis tests on current Node versions (10/12/13).
- replaced deprecated istanbul with nyc.
@simondel
Copy link
Collaborator

Released as [email protected]

@dependabot dependabot bot mentioned this issue Mar 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(infra): upgrade all deps
2 participants
@simondel @AviVahl