Merge pull request voxpupuli#39 from domcleal/37-webroot-paths

Validate presence of webroot_paths with webroot plugin

README.md

@@ -82,6 +82,19 @@ letsencrypt::certonly { 'foo':
 }
 ```
 
+To request a certificate using the `webroot` plugin, the paths to the webroots
+for all domains must be given through `webroot_paths`. If `domains` and
+`webroot_paths` are not the same length, `webroot_paths` will cycle to make up
+the difference.
+
+```puppet
+letsencrypt::certonly { 'foo':
+  domains       => ['foo.example.com', 'bar.example.com'],
+  plugin        => 'webroot',
+  webroot_paths => ['/var/www/foo', '/var/www/bar'],
+}
+```
+
 If you need to pass a command line flag to the `letsencrypt-auto` command that
 is not supported natively by this module, you can use the `additional_args`
 parameter to pass those arguments:

manifests/certonly.pp

@@ -42,6 +42,8 @@
   validate_re($plugin, ['^apache$', '^standalone$', '^webroot$'])
   if $webroot_paths {
     validate_array($webroot_paths)
+  } elsif $plugin == 'webroot' {
+    fail("The 'webroot_paths' parameter must be specified when using the 'webroot' plugin")
   }
   validate_string($letsencrypt_command)
   if $additional_args {

spec/defines/letsencrypt_certonly_spec.rb

@@ -46,6 +46,12 @@
         it { is_expected.to contain_exec('letsencrypt certonly foo').with_command 'letsencrypt --agree-tos certonly -a webroot --webroot-path /var/www/foo -d foo.example.com --webroot-path /var/www/foo -d bar.example.com' }
       end
 
+      context 'with webroot plugin and no webroot_paths' do
+        let(:title) { 'foo.example.com' }
+        let(:params) { { plugin: 'webroot' } }
+        it { is_expected.to raise_error Puppet::Error, /'webroot_paths' parameter must be specified/ }
+      end
+
       context 'with custom plugin' do
         let(:title) { 'foo.example.com' }
         let(:params) { { plugin: 'apache' } }