Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write timeout not always enforced #8649

Closed
timsehn opened this issue Dec 6, 2024 · 1 comment
Closed

Write timeout not always enforced #8649

timsehn opened this issue Dec 6, 2024 · 1 comment
Labels
bug Something isn't working sql server Issues related to the built in SQL server

Comments

@timsehn
Copy link
Contributor

timsehn commented Dec 6, 2024

Start a SQL server with a low write timeout:

$ emacs config.yaml            
$ grep write_timeout config.yaml  
  write_timeout_millis: 1
$ dolt sql-server --config=config.yaml
Starting server with Config HP="127.0.0.1:3310"|T="28800000"|R="false"|L="debug"

Run an update query with a sleep in it and it succeeds.

MySQL [config_blog]> update t set words=sleep(10) where id=5;
Query OK, 1 row affected (10.012 sec)
Rows matched: 1  Changed: 1  Warnings: 0
@timsehn timsehn added bug Something isn't working sql server Issues related to the built in SQL server labels Dec 6, 2024
@timsehn
Copy link
Contributor Author

timsehn commented Dec 10, 2024

So, this is a misunderstanding of what write_timeout_millis does. write_timeout_millis is equivalent to MySQL net_write_timeout:

https://dev.mysql.com/doc/refman/8.4/en/server-system-variables.html#sysvar_net_write_timeout

which controls how long to wait before killing a connection if you can't write to the network interface. This is really hard to trigger in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sql server Issues related to the built in SQL server
Projects
None yet
Development

No branches or pull requests

1 participant