Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ember-app-scheduler to 0.2.0 (fixes #72) #73

Merged
merged 2 commits into from
Oct 8, 2017

Conversation

YoranBrondsema
Copy link
Contributor

@YoranBrondsema YoranBrondsema commented Oct 1, 2017

Fixes #72.

@nrcjbarry would you mind trying if this fixes the issue for you too? In package.json replace the ember-router-scroll line with

"ember-router-scroll": "https://github.com/sutori/ember-router-scroll#cf69ad9ed75b53ae56104326ce05cd46f11136ed",

@nrcjbarry
Copy link

Sure, I’ll give it a try tomorrow.

@YoranBrondsema
Copy link
Contributor Author

@briangonzalez Do you mind merging and making a new release? This is blocking us from upgrading to Ember.js 2.15 :/

@nrcjbarry
Copy link

@YoranBrondsema, I just tried out your changes and I'm getting some odd behavior. I'm using Ember Mirage, and in my acceptance tests where I'm testing out a 500 error, the test freezes and doesn't continue on when it renders the page.

Just to make sure I wasn't crazy, I did an rm -rf node_modules dist tmp package-lock.json and then npm install with your changes again and still got the same behavior. If I revert using the latest ember-router-scroll, I don't see this behavior.

I checked, and Ember Mirage doesn't use ember-app-scheduler. I'm not really sure what's causing this.

@briangonzalez
Copy link
Contributor

So what's the latest here?

@YoranBrondsema
Copy link
Contributor Author

I don't mind finding a workaround for myself to use the 0.2.0 version so that I can get on with the Ember.js update. This gives @nrcjbarry some more time to figure out what is causing the issue on his side.

@nrcjbarry
Copy link

@YoranBrondsema, I figured out the issue on my side. Had to do with how I was handling the errors in the application controller's error action. Going to run my acceptance tests a bunch and see if I see the afterContentPaint issue any more.

@nrcjbarry
Copy link

nrcjbarry commented Oct 6, 2017

@YoranBrondsema, I've been running all my acceptance tests over and over for the last 15 minutes and haven't seen the afterContentPaint issue. I believe you've fixed it!

@YoranBrondsema
Copy link
Contributor Author

@nrcjbarry It wasn't me but the people from ember-app-scheduler rather :-).

Great, good to know it's working on your side too! When you're confident that it's fixed, say something here and. If @briangonzalez is so kind to merge this PR, we'll all be able to move on hehe.

@nrcjbarry
Copy link

It's going on 25 minutes now and I still haven't seen the issue. Although it was random before, it would have happened by now based on my past experience with it.

@briangonzalez, I'm good with this PR being merged if you are!

@briangonzalez briangonzalez merged commit 9de792f into DockYard:master Oct 8, 2017
@briangonzalez
Copy link
Contributor

0.4.0 released!

https://www.npmjs.com/package/ember-router-scroll

@Turbo87 Turbo87 added the bug label Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting error "Cannot read property 'afterContentPaint' of null" when running tests
4 participants