-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ember-app-scheduler to 0.2.0 (fixes #72) #73
Update ember-app-scheduler to 0.2.0 (fixes #72) #73
Conversation
Sure, I’ll give it a try tomorrow. |
@briangonzalez Do you mind merging and making a new release? This is blocking us from upgrading to Ember.js 2.15 :/ |
@YoranBrondsema, I just tried out your changes and I'm getting some odd behavior. I'm using Ember Mirage, and in my acceptance tests where I'm testing out a 500 error, the test freezes and doesn't continue on when it renders the page. Just to make sure I wasn't crazy, I did an I checked, and Ember Mirage doesn't use |
So what's the latest here? |
I don't mind finding a workaround for myself to use the 0.2.0 version so that I can get on with the Ember.js update. This gives @nrcjbarry some more time to figure out what is causing the issue on his side. |
@YoranBrondsema, I figured out the issue on my side. Had to do with how I was handling the errors in the |
@YoranBrondsema, I've been running all my acceptance tests over and over for the last 15 minutes and haven't seen the |
@nrcjbarry It wasn't me but the people from Great, good to know it's working on your side too! When you're confident that it's fixed, say something here and. If @briangonzalez is so kind to merge this PR, we'll all be able to move on hehe. |
It's going on 25 minutes now and I still haven't seen the issue. Although it was random before, it would have happened by now based on my past experience with it. @briangonzalez, I'm good with this PR being merged if you are! |
0.4.0 released! |
Fixes #72.
@nrcjbarry would you mind trying if this fixes the issue for you too? In
package.json
replace the ember-router-scroll line with