Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow public accessors to torch state and zoom level (get and set) #94

Closed
drmarkpowell opened this issue Jun 25, 2019 · 1 comment
Closed

Comments

@drmarkpowell
Copy link
Contributor

Is your feature request related to a problem? Please describe.
For our app, we would like to run Lumina as an embedded view controller within a custom UIVC and control its torch and zoom level via our own external UI buttons or similar.

Describe the solution you'd like
In addition to the LuminaViewController internal buttons, we would like to be able to set/get the LuminaCamera torch state and current zoom level programatically.

Describe alternatives you've considered
We considered using the existing LuminaViewController buttons but we're embedding the Lumina VC in a small space and the internal buttons are occluding the camera view too much (we are scanning barcodes with it).

Additional context
We are using Lumina for this app mainly to scan barcodes, within a custom UIViewController that presents a few other custom controls for related things.

Would making the LuminaCamera public be appropriate, or would adding additional set/get method to LuminaViewController be more acceptable? I'd be happy to fire a PR your way.

@dokun1
Copy link
Owner

dokun1 commented Aug 7, 2019

Hey! Thank you so much for this issue and tagging this.

I think the most appropriate way forward would be to add setters and getters for those levels. I think LuminaCamera is and should be private to prevent misuse of the interface. I have seen other use cases similar to this with the simple presence of other buttons on the UI, thanks to @gerriet and his contribution.

Let me know if you agree with this - happy to review a PR of it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants