Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update devcontainer image: v1.0.0-alpha.13 #2480

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Update devcontainer image: v1.0.0-alpha.13 #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .devcontainer/devcontainer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
// https://github.com/microsoft/vscode-dev-containers/tree/v0.245.2/containers/rust
{
"name": "Rust",
"image": "ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12",
"image": "ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Ohayo, sensei! I've noticed a discrepancy with the devcontainer image version.

  • The devcontainer.json has been updated to use v1.0.0-alpha.13.
  • However, the release notes for v1.0.0-alpha.13 mention updating the devcontainer image to v1.0.0-alpha.12.

Please update the release notes to accurately reflect the current devcontainer image version.

🔗 Analysis chain

Ohayo, sensei! The image update looks good!

The devcontainer image has been successfully updated to the latest version. This change aligns perfectly with the PR objectives.

To ensure a smooth transition, let's verify if there are any significant changes or announcements related to this new version:

If any important changes are found, please make sure to communicate them to the development team, sensei!

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check for release notes or changelogs for the new devcontainer image version

# Test: Search for any README, CHANGELOG, or release notes files
fd -i -e md -e txt '(readme|changelog|release.*notes)' | xargs rg -i 'v1\.0\.0-alpha\.13'

# Test: Check GitHub releases page for the new version
gh release view v1.0.0-alpha.13 --repo dojoengine/dojo

Length of output: 3665

"runArgs": [
"--cap-add=SYS_PTRACE",
"--security-opt",
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/bench.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
bench-katana:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
Expand All @@ -36,7 +36,7 @@ jobs:
bench-sozo:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- run: git config --global --add safe.directory "$GITHUB_WORKSPACE"
Expand Down
16 changes: 8 additions & 8 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
needs: ensure-docker
runs-on: ubuntu-latest-32-cores
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand All @@ -55,7 +55,7 @@ jobs:
ensure-wasm:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
needs: build
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/download-artifact@v4
with:
Expand All @@ -135,7 +135,7 @@ jobs:
needs: build
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/download-artifact@v4
with:
Expand All @@ -149,7 +149,7 @@ jobs:
dojo-world-bindings-check:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand All @@ -158,7 +158,7 @@ jobs:
clippy:
runs-on: ubuntu-latest-4-cores
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand All @@ -167,7 +167,7 @@ jobs:
fmt:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand All @@ -176,7 +176,7 @@ jobs:
docs:
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
steps:
- uses: actions/checkout@v3
- uses: Swatinem/rust-cache@v2
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-dispatch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
contents: write
runs-on: ubuntu-latest
container:
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.12
image: ghcr.io/dojoengine/dojo-dev:v1.0.0-alpha.13
env:
VERSION: ""
steps:
Expand Down
Loading