Skip to content

Commit

Permalink
refactor(katana): remove events trace log (#2570)
Browse files Browse the repository at this point in the history
  • Loading branch information
kariy authored Oct 22, 2024
1 parent db767df commit c2bbef9
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,6 @@ impl<'a> BlockExecutor<'a> for StarknetVMProcessor<'a> {
}

crate::utils::log_resources(&trace.actual_resources);
crate::utils::log_events(receipt.events());
}

ExecutionResult::Failed { error } => {
Expand Down
10 changes: 0 additions & 10 deletions crates/katana/executor/src/utils.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,6 @@ pub fn log_resources(resources: &TxResources) {
trace!(target: LOG_TARGET, usage = mapped_strings.join(" | "), "Transaction resource usage.");
}

pub fn log_events(events: &[Event]) {
for e in events {
trace!(
target: LOG_TARGET,
keys = e.keys.iter().map(|key| format!("{key:#x}")).collect::<Vec<_>>().join(", "),
"Event emitted.",
);
}
}

pub(crate) fn build_receipt(tx: TxRef<'_>, fee: TxFeeInfo, info: &TxExecInfo) -> Receipt {
let events = events_from_exec_info(info);
let revert_error = info.revert_error.clone();
Expand Down

1 comment on commit c2bbef9

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.30.

Benchmark suite Current: c2bbef9 Previous: db767df Ratio
Concurrent.Simulate/Blockifier.1 6473139 ns/iter (± 573836) 4592447 ns/iter (± 324662) 1.41

This comment was automatically generated by workflow using github-action-benchmark.

CC: @kariy @glihm @tarrencev

Please sign in to comment.