Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple the BTR process from the Webpack Plugin #242

Closed
wants to merge 3 commits into from

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 22, 2020

Type: feature

The following has been addressed in the PR:

Description:

In order to run build time rendering independently of the webpack build, the main process needs to be decoupled from the webpack apply API and called directly. In addition this adds a new API that enables a single page/path to be executed.

Related to dojo/cli-build-app#367

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #242 into master will decrease coverage by 0.72%.
The diff coverage is 83.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
- Coverage   83.86%   83.14%   -0.73%     
==========================================
  Files          46       46              
  Lines        2114     2142      +28     
  Branches      566      571       +5     
==========================================
+ Hits         1773     1781       +8     
- Misses        341      361      +20
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 90.08% <83.59%> (-5.01%) ⬇️
src/build-time-render/Renderer.ts 92.64% <0%> (+0.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42f9372...cea62ac. Read the comment docs.

@agubler agubler closed this Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant