Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Externals scripts/styles are not being injected into the index.html #119

Closed
agubler opened this issue Jan 21, 2019 · 1 comment
Closed

Externals scripts/styles are not being injected into the index.html #119

agubler opened this issue Jan 21, 2019 · 1 comment
Assignees
@mwistrand

Comments

@agubler
Copy link
Member

agubler commented Jan 21, 2019

Bug

The external resource that need to be injected into the index.html are not being included as expected.
@mwistrand
Copy link
Contributor

The underlying problem is that the HtmlWebpackIncludeAssetPlugin instantiated by the externals loader plugin expects to be registered after the HtmlWebpackPlugin, but @dojo/cli-build-app instantiates HtmlWebpackPlugin after the ExternalsLoaderPlugin.

@mwistrand mwistrand self-assigned this Jan 21, 2019
@mwistrand mwistrand mentioned this issue Jan 21, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwistrand mwistrand

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@agubler @mwistrand