Focus Middleware #389
Merged
Focus Middleware #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
force-pushed
the
focus-middleware
branch
from
0ac1aaf
to
29cd7f1
Compare
agubler
force-pushed
the
focus-middleware
branch
from
66c8c8a
to
3412761
Compare
matt-gadd
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Focus middleware builds on the primitive focus functionality provided by vdom and enables management of focus across widget boundaries.
The focus middleware provides a function called
shouldFocusthat manages when a widget or their child widgets can apply focus,shouldFocuswill only return true the first time it is called until focus is called again on the widget.Resolves #400