Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocking middleware is brittle #817

Closed
maier49 opened this issue Jul 16, 2020 · 0 comments · Fixed by #819
Closed

Mocking middleware is brittle #817

maier49 opened this issue Jul 16, 2020 · 0 comments · Fixed by #819
Assignees
@agubler
Labels
bug Something isn't working

Comments

@maier49
Copy link
Contributor

maier49 commented Jul 16, 2020

Bug
Currently middleware mocking relies on reference equality between the actual middleware and the middleware passed to the test renderer. For middleware that are created by factory functions this will only work if the exact instance is intentionally passed.

Package Version: 7
@maier49 maier49 added the bug Something isn't working label Jul 16, 2020
@agubler agubler self-assigned this Jul 16, 2020
@agubler agubler mentioned this issue Jul 17, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agubler agubler

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add function to create "typed" version of middleware agubler/framework
2 participants
@agubler @maier49