Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StoreProvider should be configured to always render #188

Closed
agubler opened this issue Nov 28, 2018 · 0 comments
Closed

StoreProvider should be configured to always render #188

agubler opened this issue Nov 28, 2018 · 0 comments
Labels
bug Something isn't working next Issue/Pull Request for the next major version

Comments

@agubler
Copy link
Member

agubler commented Nov 28, 2018

Bug

StoreProvider uses a render property that describes the widgets to render when it renders.

This works fine when the StoreProvider is invalidated by the store. However if the parent component is invalidated and passes a different property to the nodes in the render property, the components does not re-render.

This codesandbox that demonstrates the issue. Click "Update Messageand notice that the message doesn't change, then click "Invalidate Store" to see that the message is finally updated because theStoreProvider` widget is invalidated by the store.

@agubler agubler added bug Something isn't working next Issue/Pull Request for the next major version labels Nov 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next Issue/Pull Request for the next major version
Projects
None yet
Development

No branches or pull requests

1 participant