-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimise generated CSS #195
Conversation
Codecov Report
@@ Coverage Diff @@
## master #195 +/- ##
==========================================
+ Coverage 52.7% 52.78% +0.08%
==========================================
Files 10 10
Lines 573 574 +1
Branches 140 140
==========================================
+ Hits 302 303 +1
Misses 271 271
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, looking at the default preset I think we may want to disable
discardEmpty
and possible calc
(depending on what it does with variable calculations`.
Discard empty is risky as it could remove empty classes we're relying on for theming etc.
@tomdye I agree with |
172f66f
to
4d7f5ee
Compare
@tomdye disabled |
Type: feature
The following has been addressed in the PR:
prettier
Description:
Uses
optimize-css-assets-webpack-plugin
to optimise the built css, especially useful to remove duplicates created by inlining css variables.Resolves #63