Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise generated CSS #195

Merged
merged 3 commits into from
Nov 14, 2018
Merged

Optimise generated CSS #195

merged 3 commits into from
Nov 14, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Oct 27, 2018

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code has been formatted with prettier
  • Unit or Functional tests are included in the PR

Description:

Uses optimize-css-assets-webpack-plugin to optimise the built css, especially useful to remove duplicates created by inlining css variables.

Resolves #63

@agubler agubler requested a review from tomdye October 27, 2018 09:30
@codecov
Copy link

codecov bot commented Oct 27, 2018

Codecov Report

Merging #195 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #195      +/-   ##
==========================================
+ Coverage    52.7%   52.78%   +0.08%     
==========================================
  Files          10       10              
  Lines         573      574       +1     
  Branches      140      140              
==========================================
+ Hits          302      303       +1     
  Misses        271      271
Impacted Files Coverage Δ
src/base.config.ts 22.98% <100%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b99c49...4d7f5ee. Read the comment docs.

Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, looking at the default preset I think we may want to disable
discardEmpty and possible calc (depending on what it does with variable calculations`.
Discard empty is risky as it could remove empty classes we're relying on for theming etc.

@agubler
Copy link
Member Author

agubler commented Nov 14, 2018

@tomdye I agree with calc we should disable this but remove empty should be fine as at this point it is building the application and the empty selectors are no longer needed as a hook into the theming system.

@agubler
Copy link
Member Author

agubler commented Nov 14, 2018

@tomdye disabled calc

@agubler agubler merged commit 7a389b2 into dojo:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants