Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support features on the command line #149

Merged
merged 4 commits into from
Aug 29, 2018

Conversation

agubler
Copy link
Member

@agubler agubler commented Aug 29, 2018

Adds support for passing features via the command line and overrides the flags that are configured in the .dojorc.

# sets foo to true
dojo build -f foo

# sets foo to foo
dojo build -f foo=foo

# sets foo to foo and bar to true
dojo build -f foo=foo -f bar

Resolves #103

@codecov
Copy link

codecov bot commented Aug 29, 2018

Codecov Report

Merging #149 into master will decrease coverage by 0.89%.
The diff coverage is 40%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #149     +/-   ##
=======================================
- Coverage   56.89%    56%   -0.9%     
=======================================
  Files           8      8             
  Lines         464    475     +11     
  Branches      112    113      +1     
=======================================
+ Hits          264    266      +2     
- Misses        200    209      +9
Impacted Files Coverage Δ
src/main.ts 93.12% <40%> (-6.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3213b6b...8143a18. Read the comment docs.

@agubler agubler merged commit 7e6b785 into dojo:master Aug 29, 2018
agubler added a commit to agubler/cli-build-app that referenced this pull request Aug 29, 2018
* Support features on the command line

* Add test for the command line features

* Add ci to dojorc and override using features

* Upgrade to webpack contrib next (4.0.0-alpha.1)
agubler added a commit that referenced this pull request Aug 29, 2018
* Support features on the command line

* Add test for the command line features

* Add ci to dojorc and override using features

* Upgrade to webpack contrib next (4.0.0-alpha.1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants