-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[d3d8] Missing f(r)og in NFS Hot Pursuit 2 #4113
Comments
I just found this issue while playing the game. Fog is fine with WineD3D. Is there any additional information that is need to further troubleshoot this issue? Thanks System information
|
Everything looks good here with d3d8to9 + dxvk, including the fog.
I don't think so. We pretty much know there's a fog problem with SM1, and it's reproducible with the above trace, but at least I have no idea what the root cause actually is. |
Did you install any native libraries? I installed d3dx9_43 and d3dcompiler_47 and things improved a bit with d3d8to9 but yet cars were corrupted among other things. Without them all graphics were completely broken. Anyways, I’m just curious. It can be mesa, the GPU drivers, Wine version, etc. |
Yes, I think I have all the native d3dcompiler and d3dx9 stuff. The d3dcompiler bits are definitely a must as d3d8to9 needs them for shader disassembly. |
Makes sense. Hopefully one of the devs can look into this. |
Just sharing an update in case is useful for anyone else finding this issue and wanting to get d3d8to9 working with DXVK, as a workaround.
I don't think d3dcompiler_47 is really needed and everything seems to work without it but of course YMMV. |
On a sidenote, as of c6dc7e0, |
@casasfernando I think I've figured it out. Feel free to give this build a try and let me know if you have any issues with it: https://github.com/doitsujin/dxvk/actions/runs/13005728817/artifacts/2495705427 |
@WinterSnowfall I will do my best to test this later today and report back. |
No worries, whenever you can. It's hardly urgent.
Yes, that's about right. Also keep in mind you'll need both d3d8 and d3d9 dlls from dxvk for use with d3d8 games, otherwise things will simply crash on startup. |
Quickly tested the build in Hot Pursuit 2 and a few other games. The fog is present, didn't notice any visual regressions. Mesa 24.3.4, Intel HD Graphics 630. |
Always good to get outside confirmation. Thanks for testing. I'm doing a broader regression check with all the d3d8 titles I have around (they're quite a few, in the range of ~200) after which we'll probably merge the fix. |
Just tested the build above and I can confirm that fog is now working and I didn't observe any glitches or whatsoever (only tested a couple of races though). System information
Thanks |
I don't know where the f(r)og is. Both WineD3D and d3d8to9 + dxvk render fog correctly, while d8vk does not.
I've captured a trace using WineD3D which reproduces the issue. Fog should be instantly visible (or not) on race start, although it's a somewhat subtle effect. Looking at the lighthouse in the distance near the end of the trace provides more clarity on the matter.
P.S.: The game does indeed use a lot of VS with
exp oFog.x, -r1
, but that doesn't currently do anything fog-wise.Software information
Need for Speed: Hot Pursuit 2
System information
Apitrace file(s)
NFSHP2.trace.tar.xz
Log files
NFSHP2.log
The text was updated successfully, but these errors were encountered: