Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .NET Core 2.1 LTS support #28

Closed
Ceridan opened this issue May 15, 2020 · 2 comments
Closed

Add .NET Core 2.1 LTS support #28

Ceridan opened this issue May 15, 2020 · 2 comments
Labels
chore Updating build tasks, package manager configs, etc; no production code change

Comments

@Ceridan
Copy link
Contributor

Ceridan commented May 15, 2020

According to the https://dotnet.microsoft.com/download/dotnet-core LTS versions are: 2.1 and 3.1. We have to add support of 2.1 and run build and tests on this version too.
@Ceridan Ceridan added the chore Updating build tasks, package manager configs, etc; no production code change label May 15, 2020
@Ceridan Ceridan changed the title .NET Core 2.1 support Add .NET Core 2.1 support May 15, 2020
@Ceridan Ceridan changed the title Add .NET Core 2.1 support Add .NET Core 2.1 LTS support May 15, 2020
@Ceridan
Copy link
Contributor Author

Ceridan commented May 17, 2020

There is some problem when run tests for both netcoreapp 2.1 and 3.1 versions. See this issue: actions/setup-dotnet#88

@Ceridan Ceridan mentioned this issue May 19, 2020
Merged
@Ceridan
Copy link
Contributor Author

Ceridan commented May 19, 2020

The solution is a bit messy, because of condition in TargetFrameworks in csproj, but this is better than nothing.

Resolved in #31

@Ceridan Ceridan closed this as completed May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Updating build tasks, package manager configs, etc; no production code change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ceridan