From e3b7319bb6c5eac2beb9d52d3486566b0b6808d0 Mon Sep 17 00:00:00 2001
From: jorg-vr <jorg.vr@live.be>
Date: Tue, 24 Oct 2023 09:54:55 +0200
Subject: [PATCH] Remove extra closing div on feedback show page

---
 app/views/feedbacks/show.html.erb | 47 +++++++++++++++----------------
 1 file changed, 22 insertions(+), 25 deletions(-)

diff --git a/app/views/feedbacks/show.html.erb b/app/views/feedbacks/show.html.erb
index 9ed03614e6..e99cdd18c8 100644
--- a/app/views/feedbacks/show.html.erb
+++ b/app/views/feedbacks/show.html.erb
@@ -48,35 +48,32 @@
                 </p>
               </div>
             </div>
-            <div class="col-sm-6 order-sm-0">
+          <% end %>
+          <div class="<%=@feedback.total_attempts > 0 ? "col-sm-6 order-sm-0" : "col-sm-12" %>">
+            <% if @feedback.submission.present? %>
+              <% submission = @feedback.submission %>
+              <div class="submission-summary clearfix">
+                <span class='status-icon float-start'><%= submission_status_icon(submission, 36) %></span>
+                <span class="status-line">
+                  <%= Submission.human_enum_name(:status, submission.status) %>
+                  <% if submission.summary.present? and submission.summary.downcase != Submission.human_enum_name(:status, submission.status).downcase %>
+                    &middot; <span class='text-muted'><%= submission.summary %></span>
+                  <% end %>
+                </span>
+                <span class="by-line">
+                  <span class="text-muted small"><%= l submission.created_at, format: :submission %></span>
+                </span>
+              </div>
             <% else %>
-            <div class="col-sm-12">
+              <%= t('.no_linked_submission') %>
             <% end %>
-              <% if @feedback.submission.present? %>
-                <% submission = @feedback.submission %>
-                <div class="submission-summary clearfix">
-                  <span class='status-icon float-start'><%= submission_status_icon(submission, 36) %></span>
-                  <span class="status-line">
-                    <%= Submission.human_enum_name(:status, submission.status) %>
-                    <% if submission.summary.present? and submission.summary.downcase != Submission.human_enum_name(:status, submission.status).downcase %>
-                      &middot; <span class='text-muted'><%= submission.summary %></span>
-                    <% end %>
-                  </span>
-                  <span class="by-line">
-                    <span class="text-muted small"><%= l submission.created_at, format: :submission %></span>
-                  </span>
-                </div>
-              <% else %>
-                <%= t('.no_linked_submission') %>
-              <% end %>
-            </div>
           </div>
-          <% if @feedback.submission.present? %>
-            <div class="code-table" data-submission-id="<%= @feedback.submission.id %>">
-              <%= @feedback.submission.judge.renderer.new(@feedback.submission, current_user).parse %>
-            </div>
-          <% end %>
         </div>
+        <% if @feedback.submission.present? %>
+          <div class="code-table" data-submission-id="<%= @feedback.submission.id %>">
+            <%= @feedback.submission.judge.renderer.new(@feedback.submission, current_user).parse %>
+          </div>
+        <% end %>
       </div>
     </div>
   </div>