Bump the rubocop group with 2 updates #4979

dependabot · 2023-09-18T11:20:35Z

Bumps the rubocop group with 2 updates: rubocop-factory_bot and rubocop-rails.

Updates rubocop-factory_bot from 2.23.1 to 2.24.0

Release notes

Sourced from rubocop-factory_bot's releases.

RuboCop factory_bot v2.24.0

What's Changed

Fix FactoryBot/AssociationStyle cop to ignore explicit associations with strategy: :build. (@pirj)

Change FactoryBot/CreateList so that it is not an offense if not repeated multiple times. (@ydah)

Fix a false positive for FactoryBot/AssociationStyle when association is called in trait block and column name is keyword. (@ydah)

Fix a false positive for FactoryBot/AssociationStyle when EnforcedStyle: Explicit and using trait within trait. (@ydah)

Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically, FactoryBot/CreateList and FactoryBot/FactoryClassName to work with minitest style directory. (@ydah)

Add FactoryBot/IdSequence cop. (@owst)

Full Changelog: rubocop/rubocop-factory_bot@v2.23.1...v2.24.0

Changelog

Sourced from rubocop-factory_bot's changelog.

2.24.0 (2023-09-18)

Fix FactoryBot/AssociationStyle cop to ignore explicit associations with strategy: :build. ([@pirj])

Change FactoryBot/CreateList so that it is not an offense if not repeated multiple times. ([@ydah])

Fix a false positive for FactoryBot/AssociationStyle when association is called in trait block and column name is keyword. ([@ydah])

Fix a false positive for FactoryBot/AssociationStyle when EnforcedStyle: Explicit and using trait within trait. ([@ydah])

Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically, FactoryBot/CreateList and FactoryBot/FactoryClassName to work with minitest style directory. ([@ydah])

Add FactoryBot/IdSequence cop. ([@owst])

Commits

8deeb64 Merge pull request #67 from rubocop/bump-version
bfffe8d Bump version to v2.24.0
8e74bc1 Merge pull request #52 from owst/add_id_sequence_cop
832bb0f Add new FactoryBot/IdSequence cop
9f74ec3 Merge pull request #69 from rubocop/dependabot/github_actions/actions/checkout-4
8f6ab5f Bump actions/checkout from 3 to 4
13e3d14 Merge pull request #55 from rubocop/ydah/fix/53
4ce5025 Change FactoryBot/AssociationStyle, FactoryBot/AttributeDefinedStatically...
ec937ec Merge pull request #68 from rubocop/fix-offense
b860873 Fix rubocop offense
Additional commits viewable in compare view

Updates rubocop-rails from 2.20.2 to 2.21.1

Release notes

Sourced from rubocop-rails's releases.

RuboCop Rails 2.21.1

Bug fixes

#1108: Fix an incorrect autocorrect for Rails/TimeZone when using String#to_time. (@koic)

#1109: Fix error for Rails/RedundantActiveRecordAllMethod when all is an argument for AR methods. (@masato-bkn)

#1110: Fix false positive for Rails/RedundantActiveRecordAllMethod when all has any parameters. (@masato-bkn)

RuboCop Rails 2.21.0

New features

#1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). (@koic)

#158: Add Rails/DangerousColumnNames cop. (@r7kamura)

#1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. (@marocchino)

#967: Add new Rails/UnusedRenderContent cop. (@samrjenkins)

#1052: Add explicit style to Rails/I18nLazyLookup. (@sunny)

#1016: Add new Rails/RedundantActiveRecordAllMethod cop. (@masato-bkn)

Bug fixes

#1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. (@vlad-pisanov)

#1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. (@koic)

#1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. (@r7kamura)

#1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. (@koic)

#1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. ([@ydah][])

#1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. (@koic)

#1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. ([@fastjames][])

#1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. ([@fatkodima][])

#1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. ([@nipe0324][])

Changes

#1056: Fix database adapter detection for nested config. ([@mjankowski][])

#1031: Make Lint/SafeNavigationChain allow presence_in. (@koic)

#1080: Make Rails/HttpStatus aware of string number status. (@r7kamura)

#1094: Make Rails/TimeZone aware of String#to_time. (@koic)

#1015: Make Style/InvertibleUnlessCondition aware of Active Support methods. (@koic)

#903: Read database config for Rails/BulkChangeTable from environment variable. ([@joergschiller][])

#1058: Relax Include path for Rails/FindBy and Rails/FindEach. (@koic)

#994: Restrict DuplicateAssociation cop to ActiveRecord. ([@mjankowski][])

... (truncated)

Changelog

Sourced from rubocop-rails's changelog.

2.21.1 (2023-09-14)

Bug fixes

#1108: Fix an incorrect autocorrect for Rails/TimeZone when using String#to_time. ([@koic][])

#1109: Fix error for Rails/RedundantActiveRecordAllMethod when all is an argument for AR methods. ([@masato-bkn][])

#1110: Fix false positive for Rails/RedundantActiveRecordAllMethod when all has any parameters. ([@masato-bkn][])

2.21.0 (2023-09-09)

New features

#1075: Add new Rails/SelectMap cop that checks for uses of select(:column_name) with map(&:column_name). ([@koic][])

#158: Add Rails/DangerousColumnNames cop. ([@r7kamura][])

#1072: Add TransactionMethods config for Rails/TransactionExitStatement to detect custom transaction methods. ([@marocchino][])

#967: Add new Rails/UnusedRenderContent cop. ([@samrjenkins][])

#1052: Add explicit style to Rails/I18nLazyLookup. ([@sunny][])

#1016: Add new Rails/RedundantActiveRecordAllMethod cop. ([@masato-bkn][])

Bug fixes

#1078: Fix a false negative for Rails/LexicallyScopedActionFilter when no methods are defined. ([@vlad-pisanov][])

#1060: Fix a false positive for Rails/HttpStatus when using symbolic value that have no numeric value mapping. ([@koic][])

#1004: Fix a false-positive for Rails/RootPathnameMethods on Ruby 2.4 or lower. ([@r7kamura][])

#1066: Fix an error for Rails/FilePath when string interpolated Rails.root is followed by a message starting with .. ([@koic][])

#1049: Fix an incorrect autocorrect for Rails/FilePath when File.join with Rails.root and path starting with /. ([@ydah][])

#1045: Fix an incorrect autocorrect for Rails/NegateInclude when using Style/InverseMethods's autocorrection together. ([@koic][])

#1062: Fix autocorrection for Rails/RakeEnvironment when rake task accepts arguments. ([@fastjames][])

#1036: Fix an error for UniqueValidationWithoutIndex when db/schema.rb is empty. ([@fatkodima][])

#1042: Fix no offences for Rails/SchemaComment when create_table with multi t columns. ([@nipe0324][])

Changes

#1056: Fix database adapter detection for nested config. ([@mjankowski][])

#1031: Make Lint/SafeNavigationChain allow presence_in. ([@koic][])

#1080: Make Rails/HttpStatus aware of string number status. ([@r7kamura][])

#1094: Make Rails/TimeZone aware of String#to_time. ([@koic][])

#1015: Make Style/InvertibleUnlessCondition aware of Active Support methods. ([@koic][])

#903: Read database config for Rails/BulkChangeTable from environment variable. ([@joergschiller][])

#1058: Relax Include path for Rails/FindBy and Rails/FindEach. ([@koic][])

#994: Restrict DuplicateAssociation cop to ActiveRecord. ([@mjankowski][])

Commits

fd3681b Cut 2.21.1
eaaa688 Update Changelog
8457ca2 Merge pull request #1115 from koic/fix_an_incorrect_autocorrect_for_rails_tim...
a56fb0e Merge pull request #1114 from masato-bkn/fix/rails_redundant_active_record_al...
a731016 [Fix: #1110] Fix false positive for Rails/RedundantActiveRecordAllMethod wh...
ce6056d [Fix #1108] Fix an incorrect autocorrect for Rails/TimeZone
fc9a15a Merge pull request #1113 from masato-bkn/fix/rails_redundant_active_record_al...
fc9bf0c [Fix: #1109] Fix error for Rails/RedundantActiveRecordAllMethod when all ...
3932c01 Fix an incorrect position of a new cop entry in the changhelog
c6c4f2a Switch back docs version to master
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore <dependency name> major version will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)
@dependabot ignore <dependency name> minor version will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)
@dependabot ignore <dependency name> will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)
@dependabot unignore <dependency name> will remove all of the ignore conditions of the specified dependency
@dependabot unignore <dependency name> <ignore condition> will remove the ignore condition of the specified dependency and ignore conditions

Bumps the rubocop group with 2 updates: [rubocop-factory_bot](https://github.com/rubocop/rubocop-factory_bot) and [rubocop-rails](https://github.com/rubocop/rubocop-rails). Updates `rubocop-factory_bot` from 2.23.1 to 2.24.0 - [Release notes](https://github.com/rubocop/rubocop-factory_bot/releases) - [Changelog](https://github.com/rubocop/rubocop-factory_bot/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-factory_bot@v2.23.1...v2.24.0) Updates `rubocop-rails` from 2.20.2 to 2.21.1 - [Release notes](https://github.com/rubocop/rubocop-rails/releases) - [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop-rails@v2.20.2...v2.21.1) --- updated-dependencies: - dependency-name: rubocop-factory_bot dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rubocop - dependency-name: rubocop-rails dependency-type: direct:development update-type: version-update:semver-minor dependency-group: rubocop ... Signed-off-by: dependabot[bot] <[email protected]>

bmesuere

The tests still seem to be failing, I guess due to an unsafe autofix (-A vs -a)

jorg-vr · 2023-09-18T12:40:01Z

yes I know, I am looking at it

dependabot bot requested a review from jorg-vr as a code owner September 18, 2023 11:20

dependabot bot added the dependencies Pull requests that update a dependency file label Sep 18, 2023

dependabot bot force-pushed the dependabot/bundler/rubocop-b2b229325b branch from 94c6629 to 73c8955 Compare September 18, 2023 12:20

Fix linting

14c9cde

jorg-vr requested a review from a team as a code owner September 18, 2023 12:23

jorg-vr requested review from bmesuere and removed request for a team September 18, 2023 12:23

bmesuere requested changes Sep 18, 2023

View reviewed changes

Fix tests

9577e01

jorg-vr approved these changes Sep 18, 2023

View reviewed changes

jorg-vr requested a review from bmesuere September 18, 2023 13:09

bmesuere added the deploy naos Request a deployment on naos label Sep 18, 2023

bmesuere temporarily deployed to naos September 18, 2023 13:35 — with GitHub Actions Inactive

github-actions bot removed the deploy naos Request a deployment on naos label Sep 18, 2023

bmesuere approved these changes Sep 18, 2023

View reviewed changes

bmesuere merged commit 07a297b into main Sep 18, 2023
15 checks passed

bmesuere deleted the dependabot/bundler/rubocop-b2b229325b branch September 18, 2023 13:43

jorg-vr mentioned this pull request Sep 19, 2023

Fix docker images not being shut down #4987

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump the rubocop group with 2 updates #4979

Bump the rubocop group with 2 updates #4979

dependabot bot commented on behalf of github Sep 18, 2023 •

edited

Loading

bmesuere left a comment

jorg-vr commented Sep 18, 2023

Bump the rubocop group with 2 updates #4979

Bump the rubocop group with 2 updates #4979

Conversation

dependabot bot commented on behalf of github Sep 18, 2023 • edited Loading

RuboCop factory_bot v2.24.0

What's Changed

2.24.0 (2023-09-18)

RuboCop Rails 2.21.1

Bug fixes

RuboCop Rails 2.21.0

New features

Bug fixes

Changes

2.21.1 (2023-09-14)

Bug fixes

2.21.0 (2023-09-09)

New features

Bug fixes

Changes

bmesuere left a comment

Choose a reason for hiding this comment

jorg-vr commented Sep 18, 2023

dependabot bot commented on behalf of github Sep 18, 2023 •

edited

Loading