Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading the exercise page when not signed in causes JS errors #5575

Closed
sentry-io bot opened this issue Jun 4, 2024 · 1 comment · Fixed by #5578
Closed

Loading the exercise page when not signed in causes JS errors #5575

sentry-io bot opened this issue Jun 4, 2024 · 1 comment · Fixed by #5578
Assignees
Labels
bug Something isn't working

Comments

@sentry-io
Copy link

sentry-io bot commented Jun 4, 2024

If you open an exercise page when not signed in, the submit button is not shown (this is by design). However, some code related to setting up this button now fails causing JS errors. I added this github issue to one of the sentry errors, but multiple errors will probably be solved by this.

To reproduce: open an exercise page when not signed in and click the submissions tab.


Sentry Issue: DODONA-FRONTEND-14

TypeError: null is not an object (evaluating 'document.getElementById("activity-handin-link").addEventListener')
  at swapActionButtons (./app/assets/javascripts/exercise.ts:201:33)
  at init (./app/assets/javascripts/exercise.ts:152:13)
  at initEditor (./app/assets/javascripts/exercise.ts:193:5)
  at initExerciseShow (./app/assets/javascripts/exercise.ts:466:5)
  at afterResize (./app/assets/javascripts/exercise.ts:469:1)
...
(2 additional frame(s) were not displayed)
@sentry-io sentry-io bot added the bug Something isn't working label Jun 4, 2024
@github-project-automation github-project-automation bot moved this to Unplanned in Roadmap Jun 4, 2024
@jorg-vr jorg-vr self-assigned this Jun 4, 2024
@jorg-vr
Copy link
Contributor

jorg-vr commented Jun 4, 2024

The other enableSubmitButton issues don't seem to be related to this case...

I will research them further

@github-project-automation github-project-automation bot moved this from Unplanned to Done in Roadmap Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant