Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add plagiarism detection for evaluations #5534

Merged
merged 9 commits into from
May 28, 2024
Merged

Add plagiarism detection for evaluations #5534

merged 9 commits into from
May 28, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented May 16, 2024 •
edited
Loading

This pull request adds detect plagiarism buttons to activities in an evaluation. These generate a plagiarism report using the submissions selected for the evaluation.

I also updated the design a bit.

  • 'Evaluate' has become an outline button instead of an icon caret. This makes it much more discoverable for new users and it deserves to be seen as it is probably the primary action.
  • As there are two buttons now, I gave the exercise table full page width. The help text has been moved to an expandable details block at the top

image
image

  • Documentation update can be found at dodona-edu/dodona-edu.github.io#

Closes #5528, #2503 and #3457

@jorg-vr jorg-vr added the feature New feature or request label May 16, 2024
@jorg-vr jorg-vr self-assigned this May 16, 2024
@jorg-vr jorg-vr marked this pull request as ready for review May 21, 2024 10:06
@jorg-vr jorg-vr requested a review from a team as a code owner May 21, 2024 10:06
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team May 21, 2024 10:06
chvp
chvp approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@chvp chvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this was discussed in the initial PR, but I don't particularly like the wording "Plagiaat controleren". As far as I understand it, Dolos can never say with certainty plagiarism occurred, only whether certain submissions are similar to others.

@jorg-vr
Copy link
Contributor Author

jorg-vr commented May 22, 2024

This has not been discussed before. But I am not sure about the alternative.

I think the button should clearly state the intent of the action, which is detecting plagiarism.
More detailed information about what to do with the info, and witch caveats to take into account should be listed in Dolos.

But I am open to changing the button text if you have a good alternative suggestion

bmesuere
bmesuere requested changes May 27, 2024
View reviewed changes
app/assets/javascripts/dolos.ts Outdated Show resolved Hide resolved
app/assets/javascripts/i18n/translations.json Outdated Show resolved Hide resolved
app/views/evaluations/_exercises_progress_table.html.erb Outdated Show resolved Hide resolved
@jorg-vr jorg-vr requested a review from bmesuere May 28, 2024 08:28
@jorg-vr jorg-vr merged commit b215875 into main May 28, 2024
11 of 13 checks passed
@jorg-vr jorg-vr deleted the feat/evaluation-plagiarism branch May 28, 2024 08:36
This was referenced Jun 20, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chvp chvp chvp approved these changes

@bmesuere bmesuere bmesuere approved these changes

Assignees

@jorg-vr jorg-vr

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a Detect plagiarism button in the evaluation view
3 participants
@jorg-vr @bmesuere @chvp