Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tab scrollbar in chrome #5479

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Fix tab scrollbar in chrome #5479

merged 2 commits into from
Apr 15, 2024

Conversation

jorg-vr
Copy link
Contributor

@jorg-vr jorg-vr commented Apr 11, 2024

This pull request adds two fixes for the scroll bar on feedback tabs in chrome.

First of all the scrollbar is hidden when their is enough available width.
image

Secondly the scrollbar remains visible when scrolled down on smaller screens
image

The padding is not ideal in this case, but it is hard to make it look great with fixed heights that work both with and without scrollbar. And having it look good for the case without scrollbar seems the most common case.

image

Closes #5478

@jorg-vr jorg-vr added the bug Something isn't working label Apr 11, 2024
@jorg-vr jorg-vr self-assigned this Apr 11, 2024
@jorg-vr jorg-vr requested a review from a team as a code owner April 11, 2024 12:13
@jorg-vr jorg-vr requested review from bmesuere and chvp and removed request for a team April 11, 2024 12:13
@jorg-vr jorg-vr merged commit d987b35 into main Apr 15, 2024
14 of 15 checks passed
@jorg-vr jorg-vr deleted the fix/scrollbar branch April 15, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide unnecessary horizontal scroll bar in submission view
3 participants