Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent naming of menu options for comments on source code #4648

Closed
pdawyndt opened this issue May 18, 2023 · 2 comments · Fixed by #5057
Closed

Inconsistent naming of menu options for comments on source code #4648

pdawyndt opened this issue May 18, 2023 · 2 comments · Fixed by #5057
Labels
bug Something isn't working low priority Thing we want to see implemented at some point

Comments

@pdawyndt
Copy link
Contributor

pdawyndt commented May 18, 2023 •
edited
Loading

Menu options: 2 end with "comment", 1 doesn't.

We should also replace "annotations" by "comments" next to the buttons that select which comments are displayed inline, to make everything consistent.

image

image
@github-project-automation github-project-automation bot moved this to Unplanned in Roadmap May 18, 2023
@pdawyndt pdawyndt added the enhancement A change that isn't substantial enough to be called a feature label May 19, 2023
@bmesuere
Copy link
Member

I agree with tweaking the text of the remove option, but not with renaming annotations since they are not the same thing. Annotations are machine annotations + comments

@bmesuere bmesuere added low priority Thing we want to see implemented at some point bug Something isn't working and removed enhancement A change that isn't substantial enough to be called a feature labels May 19, 2023
@pdawyndt
Copy link
Contributor Author

Wasn't aware that we use "annotations" as an umbrella term for both machine annotations and comments, so makes sense then to keep it as is.

@bmesuere bmesuere moved this from Unplanned to Todo in Roadmap Oct 21, 2023
@bmesuere bmesuere mentioned this issue Oct 21, 2023
Merged
@github-project-automation github-project-automation bot moved this from Todo to Done in Roadmap Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working low priority Thing we want to see implemented at some point
Projects
Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Harmonize comment menu wording dodona-edu/dodona
2 participants
@bmesuere @pdawyndt