Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest invocation stripping for Python tutor fails if there is whitespace between the import and the call #3496

Closed
chvp opened this issue Mar 23, 2022 · 2 comments · Fixed by #5380
Assignees
Labels
bug Something isn't working high priority Things we want to see implemented soon

Comments

@chvp
Copy link
Member

chvp commented Mar 23, 2022

For example: https://dodona.ugent.be/nl/submissions/10253786/

@chvp chvp added the bug Something isn't working label Mar 23, 2022
@bmesuere bmesuere added this to Roadmap Apr 17, 2022
@bmesuere bmesuere moved this to Todo in Roadmap Apr 17, 2022
@bmesuere bmesuere moved this from Todo to Unplanned in Roadmap Apr 17, 2022
@bmesuere
Copy link
Member

@chvp do you still remember what goes wrong here? (i.e. what is the expected behaviour)
This might be relevant now since we're working on the Tutor.

@chvp
Copy link
Member Author

chvp commented Oct 21, 2023

This code fails if there are blank lines in the __main__ if statement (as in the linked submission). If you use the python tutor on the linked submission you will see that there is a lost doctest.testmod() in the code shown in the tutor.

Expected behaviour is that the doctest.testmod() is stripped as well (or the tutor setting __name__ to something else than "__main__" would work as well I guess).

@bmesuere bmesuere added the high priority Things we want to see implemented soon label Feb 18, 2024
@github-project-automation github-project-automation bot moved this from Unplanned to Done in Roadmap Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Things we want to see implemented soon
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants