From 82a1b6cae6877c4a232d36fb9b792986f7389094 Mon Sep 17 00:00:00 2001
From: "jorg.vr" <jorg.vanrenterghem@ugent.be>
Date: Mon, 9 Dec 2024 11:52:02 +0100
Subject: [PATCH] Always show add score items button

---
 app/assets/stylesheets/models/score_items.css.scss | 13 +++++++++----
 app/views/score_items/_exercise.html.erb           | 14 +++++++-------
 2 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/app/assets/stylesheets/models/score_items.css.scss b/app/assets/stylesheets/models/score_items.css.scss
index def6639ef6..efee2a8df1 100644
--- a/app/assets/stylesheets/models/score_items.css.scss
+++ b/app/assets/stylesheets/models/score_items.css.scss
@@ -23,11 +23,11 @@
   }
 
   td.visibility {
-    width: 20px;
+    width: 60px;
   }
 
   td.maximum {
-    width: 105px;
+    width: 100px;
     padding-right: 20px;
   }
 
@@ -40,8 +40,13 @@
     width: 250px;
   }
 
-  td.wide-description {
-    width: 650px;
+  td.add-score-items {
+    text-align: center;
+
+    // padding is used to center the button
+    // padding-right: 90px = 250px (td.name)  - 60px (td.visibility) - 100px (td.maximum)
+    // top and bottom padding is 0 to avoid double padding with the button
+    padding: 0 90px 0 0;
   }
 
   .maximum-row {
diff --git a/app/views/score_items/_exercise.html.erb b/app/views/score_items/_exercise.html.erb
index 24764e278a..5cbc1ff930 100644
--- a/app/views/score_items/_exercise.html.erb
+++ b/app/views/score_items/_exercise.html.erb
@@ -22,12 +22,7 @@
     <% if evaluation_exercise.score_items.empty? %>
       <tr>
         <td class="placeholder-text" colspan="4">
-          <div><%= t 'score_items.exercise.nothing' %></div>
-          <div>
-            <a class="btn btn-text edit-btn">
-              <%= t ".add" %>
-            </a>
-          </div>
+          <%= t 'score_items.exercise.nothing' %>
         </td>
       </tr>
     <% else %>
@@ -47,7 +42,12 @@
       <% end %>
     <% end %>
     <tr class="maximum-row">
-      <td colspan="2" class="wide-description"><%= t '.max' %></td>
+      <td class="name"><%= t '.max' %></td>
+      <td class="add-score-items">
+        <a class="btn btn-text edit-btn">
+          <%= t ".add" %>
+        </a>
+      </td>
       <td class="maximum">
         <%= format_score maximum_score %>
       </td>