-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use iframe for Playground #789
Comments
This is actually quite an important feature: every time you use global styles, or absolute styling, things get really messy. Styles also conflict with Docz styles, and responsive cannot be tested properly. |
+1 on this. I just spent quite a long time trying to work this out before releasing it wasn't supported :( Everything else about the library is amazing |
Very unfortunate that docz doesn't have |
Hi, if you are looking for built-in iframe playground solution, check out new Docz theme - Ztopia: http://docz-theme-ztopia.surge.sh :) |
@zicodeng have you thought about opening a PR for your iframe implementation to get it into docz? I think many of us would be really happy to have this built-in. |
@floriangosse Hi, I definitely thought about this. This feature will actually not be part of docz core, it is theme-specific. So I instead create another theme, which has this built in iframe Playground support: http://docz-theme-ztopia.surge.sh/ |
Can you elaborate on why it is theme specific? It looks to me like all themes should ship with this feature. |
@martpie Hi, happy to explain my thoughts! The reason why I say that is because the iframe logic is handled on the UI component level, e.g. |
This is released in the new v2. |
Seems like this requires #1305 (2.2.0-alpha.8) and use: <Playground useScoping>
...
</Playground> |
Hey all, Thanks @techniq for providing a fix ! As you said this is solved in 2.2.0. To scope your playground styles and make them independent of docz theme css you have 2 choices :
<Playground useScoping>
{
// blablabla
}
</Playground>
export default {
useScopingInPlayground: true
} If you're interested in the implementation details check out #1305 |
@rakannimer - Any thoughts on how this might work with css-modules? |
I know this is in Alpha but just wanted to let you know that this is not solved. Font's still are messed up |
@bgold0 what is in alpha? css-modules? |
The default Docz
<Playground>
is really cool, but it does not serve your components in an isolated browsing contextThe disadvantages of shared browsing context are:
I have seen multiple requests for this feature in the roadmap: http://feedback.docz.site/roadmap/p/use-iframes-for-each-playground and https://docz.canny.io/roadmap/p/open-playground-in-new-window
What is the current status of this feature? Is it in progress? I didn't see it in v1 release
If people need a temporary solution, I made a simple iframe wrapper: https://github.com/zicodeng/docz-iframe-playground
The text was updated successfully, but these errors were encountered: