Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making firebase/php-jwt version requirement more relaxed. #174

Closed
nicosp opened this issue Jun 8, 2022 · 8 comments
Closed

Consider making firebase/php-jwt version requirement more relaxed. #174

nicosp opened this issue Jun 8, 2022 · 8 comments

Comments

@nicosp
Copy link

nicosp commented Jun 8, 2022

Is it possible to change the dependency from : "firebase/php-jwt": "^5.0" to "firebase/php-jwt": "^5.0 || ^6.0" ?

The current strict dependency prevents us from updating.

@nicosp nicosp changed the title Consider makking firebase/php-jwt version requirement more relaxed. Consider making firebase/php-jwt version requirement more relaxed. Jun 8, 2022
@Adrian-DS-Support
Copy link

Adrian-DS-Support commented Jun 10, 2022

Thank you for your feedback.

We will pass it on to our engineering team, they will take this into consideration for our next release.

Our SDK is a good start, please feel free to make the necessary changes to the files.

Our PHP general guides:
https://developers.docusign.com/docs/esign-rest-api/sdk-tools/php/auth/

https://developers.docusign.com/docs/esign-rest-api/sdk-tools/php/setup-and-configuration/

@bbeckford
Copy link

We also require this dependency change, please 👍

@ArthurGuy
Copy link

Same here, it's blocking the installation of another package

@wizhippo
Copy link

Same here,

After reading the JWT 6.0 BC breaks and searching for them in the code here, non of them apply so it should be just a version bump without any issue.

@apsylone
Copy link

So long to wait for a minor fix like this... Still blocking on my side too !
@Adrian-DS-Support any news on this ticket opened 6 month ago ?

Thanks,

@klimslim
Copy link

firebase/php-jwt has a vulnerability CVE-2021-46743 that was fixed in 6.x only. This issue should definitely be fixed.

@Dr-Shadow
Copy link

This seems to be a blocking issue on our side as well.

We would like to add docusign as a new eSign provider in our application.

Any news from the SDK team about this ? @karankaushik95 @Adrian-DS-Support

@dbbrahmbhatt
Copy link
Contributor

Hello All, Thank you for filing the issue. We have added the support for firebase/php-jwt 6.* in release 6.12.0-rc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants