Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefer mbstring functions #35

Closed
greg0ire opened this issue Apr 11, 2020 · 2 comments
Closed

Prefer mbstring functions #35

greg0ire opened this issue Apr 11, 2020 · 2 comments

Comments

@greg0ire
Copy link
Member

See jdorn/sql-formatter#85

Not sure why our coding standard does not enforce that, maybe it's too risky?
greg0ire added a commit to greg0ire/sql-formatter that referenced this issue Apr 12, 2020
@greg0ire
Prefer mb_ functions
feeb6c2 
Closes doctrine#35
@greg0ire greg0ire mentioned this issue Apr 12, 2020
Closed
@goetas
Copy link
Member

goetas commented Apr 12, 2020 •
edited
Loading

Not sure if is a good idea, mb functions seems to be slower. When matching non utf8 characters, ordinary functions should be enough. Is there a case where mb is required?

@greg0ire
Copy link
Member Author

It's indeed consistently slower (according to tests/performance.php), and I tried to build a failing test case from http://baldi.me/blog/emoji-in-sql … no dice. Let's just close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prefer mb_ functions greg0ire/sql-formatter
2 participants
@greg0ire @goetas