Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate dependency on doctrine/common #7249

Closed
Majkl578 opened this issue Jun 5, 2018 · 8 comments
Closed

Eliminate dependency on doctrine/common #7249

Majkl578 opened this issue Jun 5, 2018 · 8 comments

Comments

@Majkl578
Copy link
Contributor

Majkl578 commented Jun 5, 2018

What is used through doctrine/common dependency:

  • Doctrine\Common\Util\Debug - likely to be dropped, only used in one console command and one test
  • Doctrine\Common\Event* to be extracted to doctrine/event-manager (for now)
  • Doctrine\Common\Persistence -> needs doctrine/persistence
  • Doctrine\Common\Util\Inflector -> should be switched to doctrine/inflector
  • Doctrine\Common\Lexer -> should be switched to doctrine/lexer (later removed)
  • Doctrine\Common\{PropertyChangedListener,NotifyPropertyChanged} -> likely to be merged into ORM

cross references:
DBAL: doctrine/dbal#3176
Migrations: doctrine/migrations#722

@stof
Copy link
Member

stof commented Jun 6, 2018

Doctrine\Common{PropertyChangedListener,NotifyPropertyChanged} -> likely to be merged into ORM

should they go in the ORM, or in doctrine/persistence to be reusable for the ODM projects ?

@Jean85
Copy link
Contributor

Jean85 commented Aug 7, 2018

Will this be feasible in the 2.x branch? Or are we forced to wait for 3.x due to BC?

@Ocramius
Copy link
Member

Ocramius commented Aug 7, 2018

Due to BC reasons, dropping the dependency on Doctrine\Common will be problematic here, so it will be done in such a way that the components are no longer used, but still added as dependency.

@Jean85
Copy link
Contributor

Jean85 commented Aug 7, 2018

So requiring the split packages and using Composer's provide will be a feasible upgrade path? Great!

@Majkl578
Copy link
Contributor Author

Majkl578 commented Aug 7, 2018

I don't think it's possible in 2.x, especially because of the Doctrine\Common\Proxy dependency.

@Jean85
Copy link
Contributor

Jean85 commented Aug 9, 2018

Umh... Maybe we can write down a shim/polyfill that uses ProxyManager under the hood, but provides aliases for Doctrine\Common\Proxy? Or the behavior is too different?

@Ocramius
Copy link
Member

Ocramius commented Aug 9, 2018

That's a lot of work that really isn't worth it. I already tried working towards a BC-friendly way of doing it, and it is feasible, but its at least a couple of full days of work.

@Majkl578 Majkl578 added this to the 3.0 milestone Oct 8, 2018
@Majkl578
Copy link
Contributor Author

Majkl578 commented Jan 2, 2019

Handled in #7497.

@Majkl578 Majkl578 closed this as completed Jan 2, 2019
@greg0ire greg0ire removed this from the 3.0.0 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants