Change Collection::slice() method to return an instance of Collection #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg0ire
reviewed
May 1, 2019
| * | ||
| * @psalm-return array<TKey,T> | ||
| * @psalm-return Collection<TKey, T> |
There was a problem hiding this comment.
Should we add @return static here, and then change the return type hints of implementors to self when dropping php 7.3?
There was a problem hiding this comment.
I am not sure. Can that be done in another issue/PR?
There was a problem hiding this comment.
Sure! It's a tiny detail, definitely not a blocker
Ocramius
reviewed
May 1, 2019
| @@ -268,7 +268,7 @@ public function indexOf($element) | |||
| /** | |||
| * {@inheritDoc} | |||
| */ | |||
| public function slice(int $offset, ?int $length = null) : array | |||
| public function slice(int $offset, ?int $length = null) : Collection | |||
There was a problem hiding this comment.
What is the impact of this BC break on the OSS ecosystem? Is ->slice() called often?
There was a problem hiding this comment.
I am not sure. Trying to think of a way to search for that on github somehow.
jwage
force-pushed
the
slice-return-collection
branch
from
ab0fc76
to
c694975
Compare
instead of an array.
greg0ire
force-pushed
the
slice-return-collection
branch
from
c694975
to
8e2ab7f
Compare
|
Oh I just noticed this has been taken over already. Closing in favor of #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195