Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Tock" is used but never started #306

Open
RichardTea opened this issue Jul 3, 2023 · 0 comments
Open

"Tock" is used but never started #306

RichardTea opened this issue Jul 3, 2023 · 0 comments
Labels
enhancement fixed in development branch Fixed in a development branch for the version milestone
Milestone
v2.2

Comments

@RichardTea
Copy link
Contributor

RichardTea commented Jul 3, 2023 •
edited
Loading

The "Tock" layer "ttimer" class is used in many places (eg sACNSource class), but the actual underlying QElapsedTimer is never started as Tock_StartLib() is never called.

While it seems to work (at least, most of the time), this is undefined behaviour.
QElapsedTimer Class | Qt Core 6.5.1
@RichardTea RichardTea mentioned this issue Jul 3, 2023
Merged
@marcusbirkin marcusbirkin added this to the v2.2 milestone Jul 31, 2023
@marcusbirkin marcusbirkin added the fixed in development branch Fixed in a development branch for the version milestone label Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement fixed in development branch Fixed in a development branch for the version milestone
Projects
None yet
Milestone
v2.2
Development

No branches or pull requests
2 participants
@marcusbirkin @RichardTea