fix: customising cover page background colour not working #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QingWei-Li
approved these changes
Oct 31, 2018
|
Good job. FIY please use angular commit conventions. |
|
@QingWei-Li thanks, will do |
|
@cheng-kang . Issue still present in 4.9.1, cannot see this fix over there. |
|
I just followed the Quick Start guide on the Official Website and I'm experiencing this issue. I can't change the background color or the background image. |
|
submit a fresh issue, with reproducible data. we can discuss there. Thanks for pointing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #666
Issue
[email protected]renders image without<p>wrapper, which is different from[email protected].Solution
Updating match regex in
_renderCoversolves the problem.Please makes sure these boxes are checked before submitting your PR, thank you!
masterbranch.libdirectory.