Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documents scroll underneath fixed position header #631

Closed
activedecay opened this issue Sep 28, 2018 · 6 comments
Closed

documents scroll underneath fixed position header #631

activedecay opened this issue Sep 28, 2018 · 6 comments
Labels
pinned This is to pinned the PR/Issue in order to keep it open pr welcome

Comments

@activedecay
Copy link

activedecay commented Sep 28, 2018

When clicking documentation links, using a header with a fixed position, the document scrolls underneath the header. What do you think of allowing this offset as a new config value?

inside src/core/config.js:14

windowYOffset: 0, // some user defined offset is allowed to account for fixed headers

inside export function initEvent(vm) at src/core/event/index.js:17

setWindowYOffset(vm.config.windowYOffset)

now fix up the scroll code a bit in src/core/event/scroll.js:23

end: el.getBoundingClientRect().top + window.pageYOffset - windowYOffset,
@stale
Copy link

stale bot commented Feb 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Feb 4, 2020
@stale stale bot closed this as completed Feb 11, 2020
@saioacoder
Copy link

Is this feature closed because is scheduled or because you don't feel it usefull?

It would be great to have this, I just change de docsify.js file because I needed this feature. I am not happy of doing it but I have a fixed header and I need it to work good.

Hope you add this on future release.

Thankssss :))

@anikethsaha
Copy link
Member

anikethsaha commented Feb 24, 2020

It was an old issue , so might have lost it in the list.
I would be happy if someone can submit a PR with this.

Thanks

@anikethsaha anikethsaha reopened this Feb 24, 2020
@stale stale bot removed the wontfix label Feb 24, 2020
@stale
Copy link

stale bot commented Apr 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Apr 24, 2020
@anikethsaha anikethsaha added pinned This is to pinned the PR/Issue in order to keep it open and removed wontfix labels Apr 24, 2020
@iskhakov
Copy link

I guess this issue had been fixed in #1045

@jhildenbiddle
Copy link
Member

Fixed in #1045.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned This is to pinned the PR/Issue in order to keep it open pr welcome
Projects
None yet
Development

No branches or pull requests

5 participants