-
-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade dompurify from 2.2.2 to 2.2.6 #1483
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/l6tfu5hbe |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ed7fa16:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems there has the security/snyk
issue on CI.
@anikethsaha could u plz check and fix it intead of manual upgrade?
Not sure whether I get this correctly but you are asking for a PR from snyk ? @Koooooo-7 |
yup, the PR of snyk always deletes the dependencies about |
I guess we need move the |
The reason I closed #1470 was because it was out of date, 4 versions behind |
Maybe snyk doesn't recognize this style https://github.com/docsifyjs/docsify/blob/develop/package.json#L106-L107 |
@sy-records -- Let's ping Snyk and let them know that their system appears unable to determine when two versions of the same library are listed as dependencies. Otherwise we're just going to run into this issue over and over again. Sounds like @anikethsaha maintains our account? |
I think @sy-records does have the access, right ? |
I private messaged you in discord @anikethsaha |
Replace #1470