Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken display URL's in headers #1353

Closed
1 task
arjun-1 opened this issue Aug 24, 2020 · 11 comments · Fixed by #1336 or #1404
Closed
1 task

Broken display URL's in headers #1353

arjun-1 opened this issue Aug 24, 2020 · 11 comments · Fixed by #1336 or #1404
Labels
bug confirmed as a bug
Milestone

Comments

@arjun-1
Copy link

arjun-1 commented Aug 24, 2020

Bug Report

Going from 4.11.4 to 4.11.5 we noticed that the display of our auto generated changelogs in the sidebar changed .

Steps to reproduce

Use Docsify 4.11.5 or higher. Use a sidebar backed by for example the following markdown

### [1.2.1](https://github.com) (2020-08-24)

## [1.2.0](https://github.com) (2020-08-21)


### Features

* feature a

## [1.1.0](https://github.com) (2020-07-24)


### Features

* feature b

### [1.0.35](https://github.com) (2020-06-24)


What is current behaviour

The listing of headers is malformed. Also the links are no longer working in the sidebar:
Screenshot from 2020-08-24 11-57-27

What is the expected behaviour

Proper listing of the changelog, with working links in the sidebar

Screenshot from 2020-08-24 11-57-11

Other relevant information

  • Bug does still occur when all/other plugins are disabled?

  • Your OS: Ubuntu 18.04.5 LTS

  • Node.js version: v12.16.1

  • npm/yarn version: 1.22.4

  • Browser version: 84.0.4147.135

  • Docsify version: 4.11.5

  • Docsify plugins:

Please create a reproducible sandbox

Edit 307qqv236

Mention the docsify version in which this bug was not present (if any)

4.11.4

@sy-records
Copy link
Member

Thank you for your feedback, we are aware of this issue and will fix it in the next version!

You can use the lower version for now, Or if you can build it yourself, you can use the code in #1336 to build it.

fixed via #1336

@sy-records sy-records added the bug confirmed as a bug label Aug 24, 2020
@sy-records sy-records linked a pull request Aug 24, 2020 that will close this issue
19 tasks
@Koooooo-7 Koooooo-7 added this to the 4.x milestone Sep 15, 2020
@adrianbj
Copy link
Contributor

I am also seeing this here: https://adrianbj.github.io/TracyDebugger/#/debug-bar

How far away do you think a fix will be? Thanks.

@adrianbj
Copy link
Contributor

Maybe this isn't related to the issue I am seeing, but it hasn't fixed the issue I noted above.

@sy-records
Copy link
Member

@adrianbj well, I see you used img, I'll see how to fix it later.

@adrianbj
Copy link
Contributor

@sy-records - thanks for looking into it - not sure when it stopped working properly - it was OK for many years.

@sy-records
Copy link
Member

@adrianbj done.

@adrianbj
Copy link
Contributor

Thanks @sy-records - let's hope it is merged soon so that this is actually fixed on sites using docsify.

@adrianbj
Copy link
Contributor

adrianbj commented Jan 3, 2021

@sy-records - any word on when a new version might be released so that this fix is actually applied to everyone's doc sites?

@sy-records
Copy link
Member

@adrianbj I'm not sure, but I've created a nightly version and you can use this https://github.com/sy-records/docsify-nightly

@adrianbj
Copy link
Contributor

adrianbj commented Jan 4, 2021

Thanks @sy-records - that's really helpful and everything is working with your bugfix.

Just a quick note that you omitted the /lib/ component for the path to the theme css file in the usage example in the Readme. It seems to me that you'd want to point users to the minified version inside /lib/, or am I missing something?

Thanks again!

@sy-records
Copy link
Member

Both are fine, I copied them from the document... https://docsify.js.org/#/quickstart?id=manual-initialization

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed as a bug
Projects
None yet
4 participants