Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE/FIX: Thread Spaces are a major hack and brittle #234

Open
janaka opened this issue Mar 7, 2024 · 1 comment
Open

CORE/FIX: Thread Spaces are a major hack and brittle #234

janaka opened this issue Mar 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@janaka
Copy link
Contributor

janaka commented Mar 7, 2024

Thread spaces don't have a concrete relationship with a thread. That results in very brittle logic around getting and creating thread spaces.

This needs a refactor adding a concrete space_id reference to a thread. Threads need to know about a space attached to them. Spaces do not need to know about the thread attached to them.

@janaka janaka added the enhancement New feature or request label Mar 7, 2024
@janaka
Copy link
Contributor Author

janaka commented Mar 7, 2024

@osala-eng the thread space logic is really brittle. Honestly, it's terrible. Do you remember the reasoning for going with this setup. Basically not having a proper database reference from thread to space_id is the issue afaik. I've got a fix on the hack which solve one issue not the file upload is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant